app: implement connector() and connectors - #287
Merged
Conversation
Allow browserified applications to explicitly register connectors to use in data-sources via `app.connector(name, exportsFromRequire)`. Include built-in connectors like `Memory` and `Remote` in the registry. Modify `dataSourcesFromConfig()` to resolve the connector via `app.connectors` first and only then fall back to auto-require the connector module.
Member
|
LGTM |
bajtos
added a commit
that referenced
this pull request
May 28, 2014
app: implement `connector()` and `connectors`
Member
There was a problem hiding this comment.
I missed this... but try and keep the test output clean in master. Its really hard to find these sometimes.
Member
Author
There was a problem hiding this comment.
This was an oversight, I don't rely on console logs in the tests I write. Fixed in 5b53da9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow browserified applications to explicitly register connectors
to use in data-sources via
app.connector(name, exportsFromRequire).Include built-in connectors like
MemoryandRemotein the registry.Modify
dataSourcesFromConfig()to resolve the connector viaapp.connectorsfirst and only then fall back to auto-requirethe connector module.
/to @ritch please review. This change will allow full-stack apps to register datasources via
app.dataSourcewithout ugly hacks, see your comment.